remove unreachable error code E0490
#106714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
Some changes occurred in diagnostic error codes
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
|
I think @petrochenkov is taking a break from reviewing? r? rust-lang/compiler |
|
r? @davidtwco |
Ezrashaw
force-pushed
the
remove-e0490
branch
2 times, most recently
from
2a0cff5 to
46d54de
Compare
rustbot
added
the
T-bootstrap
Ezrashaw
force-pushed
the
remove-e0490
branch
from
46d54de to
02005e9
Compare
|
@davidtwco I've fixed the comment, took a while (CI seems to hate me today). |
davidtwco
approved these changes
Jan 12, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
Noratrieb
added a commit
to Noratrieb/rust
that referenced
this pull request
Jan 12, 2023
remove unreachable error code `E0490` AFAIK, the untested and undocumented error code `E0490` is now unreachable, it was from the days of the original borrow checker. cc `@GuillaumeGomez` rust-lang#61137
This was referenced Jan 12, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 12, 2023
Rollup of 6 pull requests Successful merges: - rust-lang#105806 (Support eager subdiagnostics again) - rust-lang#106322 (Handle inference variables in `CollectAllMismatches` correctly) - rust-lang#106579 (Suggest making private tuple struct field public) - rust-lang#106714 (remove unreachable error code `E0490`) - rust-lang#106751 (Fix rendering 'const' in header for intrinsics) - rust-lang#106761 (Add `WaffleLapkin` to compiler reviewers) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
100 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK, the untested and undocumented error code
E0490is now unreachable, it was from the days of the original borrow checker.cc @GuillaumeGomez #61137